[8.x](backport #40993) Don't register cfgfile flags on flag.CommandLine in func init()#41007
Merged
pierrehilbert merged 1 commit into8.xfrom Sep 30, 2024
Merged
[8.x](backport #40993) Don't register cfgfile flags on flag.CommandLine in func init()#41007pierrehilbert merged 1 commit into8.xfrom
flag.CommandLine in func init()#41007pierrehilbert merged 1 commit into8.xfrom
Conversation
mergify
bot
requested review from
AndersonQ and
VihasMakwana
and removed request for
a team
botelastic
bot
added
the
needs_team
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
botelastic
bot
removed
the
needs_team
pierrehilbert
requested review from
blakerouse
and removed request for
AndersonQ and
VihasMakwana
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @blakerouse? 🙏 |
pierrehilbert
approved these changes
Sep 30, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Requires the explicit calling of
cfgfile.InitFlags(nil)to register the flags initialized by thecfgfilemodule.This is required to allow other modules to import beats without having those flags present in the global
flag.CommandLine. When they are automatically registered they collide and cause issues with other already registered command line arguments (aka. elastic-agent).Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works(not really possible to unit test)[ ] I have added an entry in(not user facing)CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
None
This is an automatic backport of pull request #40993 done by [Mergify](https://mergify.com).